Skip to content

chore(deps): Revert Updated airlift base and checkstyle to work with Java 17#27423

Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom
mblanco-denodo:revert_checkstyle_17
Mar 24, 2026
Merged

chore(deps): Revert Updated airlift base and checkstyle to work with Java 17#27423
tdcmeehan merged 1 commit intoprestodb:masterfrom
mblanco-denodo:revert_checkstyle_17

Conversation

@mblanco-denodo
Copy link
Copy Markdown
Contributor

@mblanco-denodo mblanco-denodo commented Mar 24, 2026 •
edited
Loading

This reverts commit 1ddef8b due to breaking JDK compatibility: #27382

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 24, 2026 •
edited
Loading

Reviewer's Guide

This PR reverts the previous dependency/checkstyle update for Java 17 compatibility by downgrading the Airbase parent POM, reverting checkstyle configuration loosening, and undoing various formatting/indentation changes, plus restoring the product test CLI wrapper to use the system Java instead of an overridden JDK path.

Flow diagram for reverted presto-cli.sh Java selection

flowchart TD
    User[User runs presto-cli.sh] --> ScriptStart[presto-cli.sh start]

    ScriptStart --> DetectJava[Detect java from system PATH]
    DetectJava --> JavaFound{java executable found?}

    JavaFound -- Yes --> RunCLI[Invoke Presto CLI using system java]
    JavaFound -- No --> ErrorOut[Print error and exit]

    RunCLI --> End[CLI session runs]
    ErrorOut --> End
Loading

File-Level Changes

Change Details Files
Revert dependency baseline to previous Airbase parent version to undo Java 17–related changes.
  • Change parent POM airbase version from 109 back to 108
 pom.xml
Restore previous Pinot connector exception construction style and indentation without changing behavior.
  • Re-indent PinotException constructor calls in broker page source common response handling and row population logic
  • Re-indent Pinot segment page source error handling and validation exceptions
 presto-pinot-toolkit/src/main/java/com/facebook/presto/pinot/PinotBrokerPageSource.java
presto-pinot-toolkit/src/main/java/com/facebook/presto/pinot/PinotPageSourceProvider.java
presto-pinot-toolkit/src/main/java/com/facebook/presto/pinot/PinotSegmentPageSource.java
Revert assorted formatting-only changes introduced by the previous Java 17/checkstyle update.
  • Adjust indentation of builder calls and chained methods in Spark query runner setup, native query runner utils, and native execution config module
  • Tighten else-if brace style and empty catch formatting in tests and client code
  • Normalize spacing in TDigestUtils swap method varargs and test plan builders
 presto-spark-base/src/test/java/com/facebook/presto/spark/PrestoSparkQueryRunner.java
presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeGeneralQueries.java
presto-main-base/src/main/java/com/facebook/presto/execution/resourceGroups/InternalResourceGroupManager.java
presto-main-base/src/test/java/com/facebook/presto/operator/scalar/BenchmarkTransformValue.java
presto-client/src/main/java/okhttp/internal/tls/DistinguishedNameParser.java
presto-main/src/test/java/com/facebook/presto/server/security/TestInternalAuthenticationFilter.java
presto-main-base/src/main/java/com/facebook/presto/resourcemanager/RatisServer.java
presto-main-base/src/main/java/com/facebook/presto/tdigest/TDigestUtils.java
presto-main-base/src/test/java/com/facebook/presto/sql/planner/iterative/rule/TestPullConstantsAboveGroupBy.java
presto-main-base/src/test/java/com/facebook/presto/sql/planner/iterative/rule/TestRedundantLimitRemoval.java
presto-native-execution/src/test/java/com/facebook/presto/spark/PrestoSparkNativeQueryRunnerUtils.java
presto-spark-base/src/main/java/com/facebook/presto/spark/execution/property/NativeExecutionConfigModule.java
Re-tighten checkstyle configuration that had been relaxed for Java 17–related rules.
  • Remove elementStyle=ignore from AnnotationUseStyle module in both Java and native checkstyle configurations
 src/checkstyle/presto-checks.xml
presto-native-execution/src/checkstyle/presto-checks.xml
Restore product test CLI launcher to use the default Java on PATH instead of a hardcoded override JDK with verbose version logging.
  • Remove JAVA_HOME override and java version echoing
  • Invoke presto-cli with plain java -jar using CLI arguments
 presto-product-tests/conf/docker/files/presto-cli.sh

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mblanco-denodo mblanco-denodo changed the title Revert "chore(deps): Updated airlift base and checkstyle to work with… chore(deps): Revert Updated airlift base and checkstyle to work with Java 17 Mar 24, 2026
@tdcmeehan tdcmeehan merged commit 70c064b into prestodb:master Mar 24, 2026
80 of 83 checks passed
@hantangwangd hantangwangd mentioned this pull request Mar 25, 2026
Closed
@mblanco-denodo mblanco-denodo mentioned this pull request Mar 25, 2026
Draft
7 tasks
This was referenced Mar 31, 2026
Closed
Open
@prestodb-ci prestodb-ci mentioned this pull request Apr 1, 2026
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@tdcmeehan tdcmeehan tdcmeehan approved these changes

@shrinidhijoshi shrinidhijoshi Awaiting requested review from shrinidhijoshi shrinidhijoshi is a code owner

@jaystarshot jaystarshot Awaiting requested review from jaystarshot jaystarshot is a code owner

@feilong-liu feilong-liu Awaiting requested review from feilong-liu feilong-liu is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mblanco-denodo @tdcmeehan